From 706c72d6f1889736812242a9dd849267e4340b51 Mon Sep 17 00:00:00 2001 From: Parvathi Mallampalli Date: Fri, 27 Aug 2021 13:29:13 -0700 Subject: [PATCH] removed converting url to uri before getting path to avoid decoding --- .../SellingPartnerAPIAA/SignableRequestImpl.java | 9 ++------- .../SellingPartnerAPIAA/SignableRequestImplTest.java | 11 +++++++++++ 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/clients/sellingpartner-api-aa-java/src/com/amazon/SellingPartnerAPIAA/SignableRequestImpl.java b/clients/sellingpartner-api-aa-java/src/com/amazon/SellingPartnerAPIAA/SignableRequestImpl.java index 9e0d196..636634a 100644 --- a/clients/sellingpartner-api-aa-java/src/com/amazon/SellingPartnerAPIAA/SignableRequestImpl.java +++ b/clients/sellingpartner-api-aa-java/src/com/amazon/SellingPartnerAPIAA/SignableRequestImpl.java @@ -73,13 +73,8 @@ class SignableRequestImpl implements SignableRequest { @Override public String getResourcePath() { - try { - return originalRequest.url() - .toURI() - .getPath(); - } catch (URISyntaxException e) { - throw new RuntimeException(e); - } + return originalRequest.url() + .getPath(); } @Override diff --git a/clients/sellingpartner-api-aa-java/tst/com/amazon/SellingPartnerAPIAA/SignableRequestImplTest.java b/clients/sellingpartner-api-aa-java/tst/com/amazon/SellingPartnerAPIAA/SignableRequestImplTest.java index f370944..c6a87de 100644 --- a/clients/sellingpartner-api-aa-java/tst/com/amazon/SellingPartnerAPIAA/SignableRequestImplTest.java +++ b/clients/sellingpartner-api-aa-java/tst/com/amazon/SellingPartnerAPIAA/SignableRequestImplTest.java @@ -68,6 +68,17 @@ public class SignableRequestImplTest { assertEquals("/request/library", underTest.getResourcePath()); } + @Test + public void getResourcePathWithPoundChar() { + testRequest = new Request.Builder() + .url("http://www.amazon.com/request/%23library") + .get() + .build(); + underTest = new SignableRequestImpl(testRequest); + + assertEquals("/request/%23library", underTest.getResourcePath()); + } + @Test public void noTimeOffset() { assertEquals(0, underTest.getTimeOffset());